Praise be to Allah.
If the trousers contain nothing haraam and are loose and do not reveal the shape of the private parts, there is nothing wrong with tucking the shirt into the pants, but if they are tight around the area of the private parts, it is necessary to cover that with the shirt or with something else.
And Allaah knows best.
